From: Christian Hofstaedtler <christian@hofstaedtler.name>
Date: Sun, 8 Sep 2013 11:54:17 +0000 (+0200)
Subject: luabackend: remove dead returns
X-Git-Tag: rec-3.6.0-rc1~451^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=904111b15a07555f97e2e1743d336a21ea1fe6e3;p=pdns

luabackend: remove dead returns
---

diff --git a/modules/luabackend/minimal.cc b/modules/luabackend/minimal.cc
index f3b27bd32..3229b3d93 100644
--- a/modules/luabackend/minimal.cc
+++ b/modules/luabackend/minimal.cc
@@ -72,7 +72,6 @@ bool LUABackend::list(const string &target, int domain_id) {
 	lua_pop(lua, 1);
 	
 	throw runtime_error(e);
-	return false;
     }
     
     size_t returnedwhat = lua_type(lua, -1);
diff --git a/modules/luabackend/reload.cc b/modules/luabackend/reload.cc
index 0be7347b2..d8ab75cf6 100644
--- a/modules/luabackend/reload.cc
+++ b/modules/luabackend/reload.cc
@@ -168,7 +168,6 @@ void LUABackend::rediscover(string* status) {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
diff --git a/modules/luabackend/slave.cc b/modules/luabackend/slave.cc
index a77b64ec7..a2d2959a1 100644
--- a/modules/luabackend/slave.cc
+++ b/modules/luabackend/slave.cc
@@ -52,7 +52,6 @@ bool LUABackend::startTransaction(const string &qname, int id) {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return false;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
@@ -84,7 +83,6 @@ bool LUABackend::commitTransaction() {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return false;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
@@ -116,7 +114,6 @@ bool LUABackend::abortTransaction() {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return false;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
@@ -148,7 +145,6 @@ bool LUABackend::feedRecord(const DNSResourceRecord &rr) {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return false;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
@@ -239,7 +235,6 @@ bool LUABackend::isMaster(const string &domain, const string &ip) {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return false;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
@@ -272,7 +267,6 @@ bool LUABackend::getDomainInfo(const string &domain, DomainInfo &di) {
         lua_pop(lua, 1);
 
         throw runtime_error(e);
-        return false;
     }
 
     size_t returnedwhat = lua_type(lua, -1);
diff --git a/pdns/lua-auth.cc b/pdns/lua-auth.cc
index effcdf062..1bd732faf 100644
--- a/pdns/lua-auth.cc
+++ b/pdns/lua-auth.cc
@@ -232,7 +232,6 @@ DNSPacket* AuthLua::prequery(DNSPacket *p)
 
     lua_pop(d_lua, 1);
     throw runtime_error(error);
-    return 0;
   }
   bool res=lua_toboolean(d_lua, 1);
   lua_pop(d_lua, 1);