From: Ruben d'Arco Date: Mon, 10 Jun 2013 20:45:52 +0000 (+0200) Subject: First stab at resolving coverity warnings X-Git-Tag: rec-3.6.0-rc1~686^2~1 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8fb03db75947122da4e5425c4b517a46c54046f3;p=pdns First stab at resolving coverity warnings --- diff --git a/modules/tinydnsbackend/tinydnsbackend.cc b/modules/tinydnsbackend/tinydnsbackend.cc index 36e1984f6..96a219db8 100644 --- a/modules/tinydnsbackend/tinydnsbackend.cc +++ b/modules/tinydnsbackend/tinydnsbackend.cc @@ -61,17 +61,20 @@ TinyDNSBackend::TinyDNSBackend(const string &suffix) d_locations = mustDo("locations"); d_ignorebogus = mustDo("ignore-bogus-records"); d_taiepoch = 4611686018427387904ULL + getArgAsNum("tai-adjust"); + d_dnspacket = NULL; + d_cdbReader = NULL; + d_isAxfr = false; + d_isWildcardQuery = false; } void TinyDNSBackend::getUpdatedMasters(vector* retDomains) { Lock l(&s_domainInfoLock); //TODO: We could actually lock less if we do it per suffix. - TDI_t *domains; if (! s_domainInfo.count(d_suffix)) { - domains = new TDI_t; - s_domainInfo[d_suffix] = *domains; - } - domains = &s_domainInfo[d_suffix]; + TDI_t *tmp = new TDI_t(); + s_domainInfo.insert( make_pair(d_suffix,*tmp) ); + } + TDI_t *domains = &s_domainInfo[d_suffix]; vector allDomains; getAllDomains(&allDomains);