From: Jacek Konieczny Date: Wed, 11 Jun 2014 08:47:45 +0000 (+0200) Subject: pull: do not abuse 'break' inside a shell 'case' X-Git-Tag: v2.0.1~30 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8f92c7755ef2e2802e24eeb3a7de1727045950c0;p=git pull: do not abuse 'break' inside a shell 'case' It is not C. The code would break under mksh when 'pull.ff' is set: $ git pull /usr/lib/git-core/git-pull[67]: break: can't break Already up-to-date. Signed-off-by: Jacek Konieczny Signed-off-by: Junio C Hamano --- diff --git a/git-pull.sh b/git-pull.sh index 6cd8ebc534..7358fac864 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -58,11 +58,9 @@ pull_ff=$(git config pull.ff) case "$pull_ff" in false) no_ff=--no-ff - break ;; only) ff_only=--ff-only - break ;; esac