From: Pierre Joye <pajoye@php.net>
Date: Sat, 24 Feb 2007 19:09:18 +0000 (+0000)
Subject: - MFB: Fixed snprintf() usage
X-Git-Tag: RELEASE_1_0_1~165
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8efa71db4a7c29234cf9b0e2e0b2febc032e46e3;p=php

- MFB: Fixed snprintf() usage
---

diff --git a/ext/zip/lib/zip_close.c b/ext/zip/lib/zip_close.c
index bd6b59dcfa..61d7583729 100644
--- a/ext/zip/lib/zip_close.c
+++ b/ext/zip/lib/zip_close.c
@@ -528,12 +528,14 @@ _zip_create_temp_output(struct zip *za, FILE **outp)
     int tfd;
     FILE *tfp;
 
-    if ((temp=(char *)malloc(strlen(za->zn)+8)) == NULL) {
+    int len = strlen(za->zn) + 8;
+
+    if ((temp=(char *)malloc(len)) == NULL) {
 	_zip_error_set(&za->error, ZIP_ER_MEMORY, 0);
 	return NULL;
     }
 
-    snprintf(temp, sizeof(temp), "%s.XXXXXX", za->zn);
+    snprintf(temp, len, "%s.XXXXXX", za->zn);
 
     if ((tfd=mkstemp(temp)) == -1) {
 	_zip_error_set(&za->error, ZIP_ER_TMPOPEN, errno);