From: Stefan Fritsch <sf@apache.org>
Date: Tue, 28 Dec 2010 14:53:59 +0000 (+0000)
Subject: Log a trace message if we drop a header with an invalid name
X-Git-Tag: 2.3.11~328
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8ef0eb9c777ac94d84780ed71a513977d321892a;p=apache

Log a trace message if we drop a header with an invalid name


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1053365 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/util_script.c b/server/util_script.c
index 2a5dec20c1..d8c3f1f297 100644
--- a/server/util_script.c
+++ b/server/util_script.c
@@ -54,9 +54,9 @@
 
 APLOG_USE_MODULE(core);
 
-static char *http2env(apr_pool_t *a, const char *w)
+static char *http2env(request_rec *r, const char *w)
 {
-    char *res = (char *)apr_palloc(a, sizeof("HTTP_") + strlen(w));
+    char *res = (char *)apr_palloc(r->pool, sizeof("HTTP_") + strlen(w));
     char *cp = res;
     char c;
 
@@ -74,6 +74,9 @@ static char *http2env(apr_pool_t *a, const char *w)
             *cp++ = '_';
         }
         else {
+            ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
+                          "Not exporting header with invalid name as envvar: %s",
+                          ap_escape_logitem(r->pool, w));
             return NULL;
         }
     }
@@ -188,7 +191,7 @@ AP_DECLARE(void) ap_add_common_vars(request_rec *r)
         }
 #endif
         else
-            add_unless_null(e, http2env(r->pool, hdrs[i].key), hdrs[i].val);
+            add_unless_null(e, http2env(r, hdrs[i].key), hdrs[i].val);
     }
 
     env_temp = apr_table_get(r->subprocess_env, "PATH");