From: Evgeniy Stepanov Date: Wed, 16 Jul 2014 08:46:35 +0000 (+0000) Subject: Don't add -Bsymbolic by default on Android. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8eb491465fea4d999a1c15714b1caeea18b12f9a;p=clang Don't add -Bsymbolic by default on Android. -Bsymbolic is not a platform requirement and should not be added unconditionally. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@213126 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 93f6e3ed1e..8b8da3013e 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -7168,9 +7168,6 @@ void gnutools::Link::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-static"); } else if (Args.hasArg(options::OPT_shared)) { CmdArgs.push_back("-shared"); - if (isAndroid) { - CmdArgs.push_back("-Bsymbolic"); - } } if (ToolChain.getArch() == llvm::Triple::arm || diff --git a/test/Driver/linux-ld.c b/test/Driver/linux-ld.c index 873cbccb6b..6a47d08274 100644 --- a/test/Driver/linux-ld.c +++ b/test/Driver/linux-ld.c @@ -830,7 +830,7 @@ // RUN: -shared \ // RUN: | FileCheck --check-prefix=CHECK-ANDROID-SO %s // CHECK-ANDROID-SO: "{{.*}}ld{{(.exe)?}}" "--sysroot=[[SYSROOT:[^"]+]]" -// CHECK-ANDROID-SO: "-Bsymbolic" +// CHECK-ANDROID-SO-NOT: "-Bsymbolic" // CHECK-ANDROID-SO: "{{.*}}{{/|\\\\}}crtbegin_so.o" // CHECK-ANDROID-SO: "-L[[SYSROOT]]/usr/lib" // CHECK-ANDROID-SO-NOT: "gcc_s"