From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 16 May 2018 11:46:32 +0000 (-0700)
Subject: bpo-33534: Remove unneeded test. (GH-6897)
X-Git-Tag: v3.7.0b5~108
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8e20fc388f1f1e6b2b38bf11995322c274b4d43a;p=python

bpo-33534: Remove unneeded test. (GH-6897)


This condition as already tested before this code is called.
(cherry picked from commit 9285835a05ad0319acef111340266c0f85ed549c)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
---

diff --git a/Lib/dataclasses.py b/Lib/dataclasses.py
index 480c6f7416..bb77d3b405 100644
--- a/Lib/dataclasses.py
+++ b/Lib/dataclasses.py
@@ -544,12 +544,11 @@ def _hash_fn(fields):
 
 
 def _is_classvar(a_type, typing):
-    if typing:
-        # This test uses a typing internal class, but it's the best
-        # way to test if this is a ClassVar.
-        return (a_type is typing.ClassVar
-                or (type(a_type) is typing._GenericAlias
-                    and a_type.__origin__ is typing.ClassVar))
+    # This test uses a typing internal class, but it's the best way to
+    # test if this is a ClassVar.
+    return (a_type is typing.ClassVar
+            or (type(a_type) is typing._GenericAlias
+                and a_type.__origin__ is typing.ClassVar))
 
 
 def _is_initvar(a_type, dataclasses):