From: David Majnemer <david.majnemer@gmail.com>
Date: Mon, 31 Oct 2016 17:11:23 +0000 (+0000)
Subject: SymbolRef::Type is not a bitfield and must be compared directly
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8d99748c3ec0128ab7daa803ecaf328d51276629;p=llvm

SymbolRef::Type is not a bitfield and must be compared directly

Found by PVS-Studio.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285597 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/tools/dsymutil/MachODebugMapParser.cpp b/tools/dsymutil/MachODebugMapParser.cpp
index e5a0535949d..051c1e941ef 100644
--- a/tools/dsymutil/MachODebugMapParser.cpp
+++ b/tools/dsymutil/MachODebugMapParser.cpp
@@ -445,7 +445,7 @@ void MachODebugMapParser::loadMainBinarySymbols(
     }
     SymbolRef::Type Type = *TypeOrErr;
     // Skip undefined and STAB entries.
-    if ((Type & SymbolRef::ST_Debug) || (Type & SymbolRef::ST_Unknown))
+    if ((Type == SymbolRef::ST_Debug) || (Type == SymbolRef::ST_Unknown))
       continue;
     // The only symbols of interest are the global variables. These
     // are the only ones that need to be queried because the address