From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Wed, 17 Jan 2018 23:51:27 +0000 (-0800) Subject: Use assertCountEqual instead of assertEqual. (GH-5223) (#5225) X-Git-Tag: v3.6.5rc1~151 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8d1e41d4148a69b0709fc7fb6bb733451ae1b28d;p=python Use assertCountEqual instead of assertEqual. (GH-5223) (#5225) This test doesn't care about order, the underlying filesystem APIs do not guarantee directory listings on subsequent calls will be in the same order. (cherry picked from commit 3941499d6c2a4d09f2ea476f84b9c4ddc4bdefa0) --- diff --git a/Lib/test/test_glob.py b/Lib/test/test_glob.py index dce64f9fcb..767bd3764b 100644 --- a/Lib/test/test_glob.py +++ b/Lib/test/test_glob.py @@ -49,10 +49,10 @@ class GlobTests(unittest.TestCase): pattern = os.path.join(*parts) p = os.path.join(self.tempdir, pattern) res = glob.glob(p, **kwargs) - self.assertEqual(list(glob.iglob(p, **kwargs)), res) + self.assertCountEqual(glob.iglob(p, **kwargs), res) bres = [os.fsencode(x) for x in res] - self.assertEqual(glob.glob(os.fsencode(p), **kwargs), bres) - self.assertEqual(list(glob.iglob(os.fsencode(p), **kwargs)), bres) + self.assertCountEqual(glob.glob(os.fsencode(p), **kwargs), bres) + self.assertCountEqual(glob.iglob(os.fsencode(p), **kwargs), bres) return res def assertSequencesEqual_noorder(self, l1, l2):