From: Matt Beaumont-Gay <matthewbg@google.com>
Date: Mon, 7 Nov 2011 18:30:47 +0000 (+0000)
Subject: Better fix for -Wnon-virtual-dtor
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8cacea57b6cd288f7578200e4884ab56bafc1a32;p=clang

Better fix for -Wnon-virtual-dtor

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@143972 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaPseudoObject.cpp b/lib/Sema/SemaPseudoObject.cpp
index b8497e5f02..b3ed145b15 100644
--- a/lib/Sema/SemaPseudoObject.cpp
+++ b/lib/Sema/SemaPseudoObject.cpp
@@ -141,8 +141,6 @@ namespace {
       : S(S), ResultIndex(PseudoObjectExpr::NoResult),
         GenericLoc(genericLoc) {}
 
-    virtual ~PseudoOpBuilder() {}
-
     /// Add a normal semantic expression.
     void addSemanticExpr(Expr *semantic) {
       Semantics.push_back(semantic);
@@ -181,6 +179,9 @@ namespace {
     virtual ExprResult buildGet() = 0;
     virtual ExprResult buildSet(Expr *, SourceLocation,
                                 bool captureSetValueAsResult) = 0;
+
+  protected:
+    ~PseudoOpBuilder() {}
   };
 
   /// A PseudoOpBuilder for Objective-C @properties.