From: Victor Stinner Date: Fri, 21 Feb 2014 22:54:32 +0000 (+0100) Subject: Issue #11188, #19748: mktime() returns -1 on error. On Linux, the tm_wday field X-Git-Tag: v3.4.1rc1~233^2~247 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8c8b4e0ebf5f58fae2d10453cda9d4ee614794d9;p=python Issue #11188, #19748: mktime() returns -1 on error. On Linux, the tm_wday field is used as a sentinel () to detect if -1 is really an error or a valid timestamp. On AIX, tm_wday is unchanged even on success and so cannot be used as a sentinel. --- diff --git a/Lib/test/test_time.py b/Lib/test/test_time.py index 2aa22969d7..be7ddcc34d 100644 --- a/Lib/test/test_time.py +++ b/Lib/test/test_time.py @@ -346,6 +346,13 @@ class TimeTestCase(unittest.TestCase): def test_mktime(self): # Issue #1726687 for t in (-2, -1, 0, 1): + if sys.platform.startswith('aix') and t == -1: + # Issue #11188, #19748: mktime() returns -1 on error. On Linux, + # the tm_wday field is used as a sentinel () to detect if -1 is + # really an error or a valid timestamp. On AIX, tm_wday is + # unchanged even on success and so cannot be used as a + # sentinel. + continue try: tt = time.localtime(t) except (OverflowError, OSError):