From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Fri, 12 Aug 2016 21:03:54 +0000 (-0600)
Subject: Flags always have a NULL value.  Regression introduced by refactor
X-Git-Tag: SUDO_1_8_18^2~74
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8c2b6fb34e1aecdb56d5fc97f2300a197c5e5ecb;p=sudo

Flags always have a NULL value.  Regression introduced by refactor
of set_default_entry().
---

diff --git a/plugins/sudoers/defaults.c b/plugins/sudoers/defaults.c
index ace368d39..03e33bc74 100644
--- a/plugins/sudoers/defaults.c
+++ b/plugins/sudoers/defaults.c
@@ -196,7 +196,7 @@ set_default_entry(struct sudo_defs_types *def, const char *val, int op,
     int rc;
     debug_decl(set_default_entry, SUDOERS_DEBUG_DEFAULTS)
 
-    if (val == NULL) {
+    if (val == NULL && !ISSET(def->type, T_FLAG)) {
 	/* Check for bogus boolean usage or missing value if non-boolean. */
 	if (!ISSET(def->type, T_BOOL) || op != false) {
 	    if (!quiet)