From: Yang Tse <yangsita@gmail.com>
Date: Wed, 24 Jul 2013 14:44:37 +0000 (+0200)
Subject: imap.c: imap_sendf() fix va_start/va_end matching
X-Git-Tag: curl-7_32_0~60
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8c1e3bb7139bc960dab78a8cc537c082a98733e4;p=curl

imap.c: imap_sendf() fix va_start/va_end matching
---

diff --git a/lib/imap.c b/lib/imap.c
index 3547a3467..ea175e6b9 100644
--- a/lib/imap.c
+++ b/lib/imap.c
@@ -2063,7 +2063,8 @@ static CURLcode imap_sendf(struct connectdata *conn, const char *fmt, ...)
   struct imap_conn *imapc = &conn->proto.imapc;
   char *taggedfmt;
   va_list ap;
-  va_start(ap, fmt);
+
+  DEBUGASSERT(fmt);
 
   /* Calculate the next command ID wrapping at 3 digits */
   imapc->cmdid = (imapc->cmdid + 1) % 1000;
@@ -2078,10 +2079,11 @@ static CURLcode imap_sendf(struct connectdata *conn, const char *fmt, ...)
     return CURLE_OUT_OF_MEMORY;
 
   /* Send the data with the tag */
+  va_start(ap, fmt);
   result = Curl_pp_vsendf(&imapc->pp, taggedfmt, ap);
+  va_end(ap);
 
   Curl_safefree(taggedfmt);
-  va_end(ap);
 
   return result;
 }