From: Martin v. Löwis <martin@v.loewis.de>
Date: Sat, 26 Oct 2002 15:01:53 +0000 (+0000)
Subject: Patch #627105: Document that SYSTEM_PAGE_SIZE really should not be
X-Git-Tag: v2.3c1~3669
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8c1402869ba0cb0a690a5168ac4067483d39e02e;p=python

Patch #627105: Document that SYSTEM_PAGE_SIZE really should not be
larger than the system page size.
---

diff --git a/Objects/obmalloc.c b/Objects/obmalloc.c
index 753b2ccfbc..a72d05aaf5 100644
--- a/Objects/obmalloc.c
+++ b/Objects/obmalloc.c
@@ -139,7 +139,10 @@
  * getpagesize() call or deduced from various header files. To make
  * things simpler, we assume that it is 4K, which is OK for most systems.
  * It is probably better if this is the native page size, but it doesn't
- * have to be.
+ * have to be.  In theory, if SYSTEM_PAGE_SIZE is larger than the native page 
+ * size, then `POOL_ADDR(p)->arenaindex' could rarely cause a segmentation 
+ * violation fault.  4K is apparently OK for all the platforms that python 
+ * currently targets.
  */
 #define SYSTEM_PAGE_SIZE	(4 * 1024)
 #define SYSTEM_PAGE_SIZE_MASK	(SYSTEM_PAGE_SIZE - 1)