From: Harald Radi <phanto@php.net>
Date: Wed, 24 Apr 2002 15:46:40 +0000 (+0000)
Subject: MFZE1 saschas 'Avoid exceeding buffer limits' patch
X-Git-Tag: php-4.3.0dev-ZendEngine2-Preview1~447
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8bf59c8fd0a0988680791ed793af84fd6a7a2a74;p=php

MFZE1 saschas 'Avoid exceeding buffer limits' patch
---

diff --git a/Zend/zend_API.c b/Zend/zend_API.c
index 67db62a218..015197ca68 100644
--- a/Zend/zend_API.c
+++ b/Zend/zend_API.c
@@ -456,9 +456,10 @@ static int zend_parse_arg(int arg_num, zval **arg, va_list *va, char **spec, int
 	expected_type = zend_parse_arg_impl(arg, va, spec);
 	if (expected_type) {
 		if (!quiet) {
-			sprintf(buf, "%s() expects parameter %d to be %s, %s given",
+			snprintf(buf, sizeof(buf)-1, "%s() expects parameter %d to be %s, %s given",
 					get_active_function_name(TSRMLS_C), arg_num, expected_type,
 					zend_zval_type_name(*arg));
+			buf[sizeof(buf)-1] = '\0';
 			zend_error(E_WARNING, buf);
 		}
 		return FAILURE;