From: Christian Heimes <christian@cheimes.de>
Date: Thu, 8 Nov 2007 16:34:32 +0000 (+0000)
Subject: Fixed #1403 where compileall and py_compile choked on an encoding header in a py... 
X-Git-Tag: v3.0a2~214
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8bd14fb398b1b89c82defdac6c5755c9ca86859b;p=python

Fixed #1403 where compileall and py_compile choked on an encoding header in a py file. Both modules need more unit tests.
---

diff --git a/Lib/io.py b/Lib/io.py
index b305b53bb0..c2f5d3ebfa 100644
--- a/Lib/io.py
+++ b/Lib/io.py
@@ -1063,6 +1063,9 @@ class TextIOWrapper(TextIOBase):
                 else:
                     encoding = locale.getpreferredencoding()
 
+        if not isinstance(encoding, str):
+            raise ValueError("invalid encoding: %r" % encoding)
+
         self.buffer = buffer
         self._encoding = encoding
         self._readuniversal = not newline
diff --git a/Lib/py_compile.py b/Lib/py_compile.py
index f7a200204c..912972bcac 100644
--- a/Lib/py_compile.py
+++ b/Lib/py_compile.py
@@ -88,7 +88,7 @@ def read_encoding(file, default):
                 break
             m = re.match(r".*\bcoding:\s*(\S+)\b", line)
             if m:
-                return str(m.group(1))
+                return m.group(1).decode("ascii")
         return default
     finally:
         f.close()