From: Ted Kremenek Date: Fri, 15 Jan 2010 07:43:59 +0000 (+0000) Subject: Convert a few more uses of std::string& to llvm::StringRef. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8b9317186fd5243938128a0b0e0494498d78ab8c;p=clang Convert a few more uses of std::string& to llvm::StringRef. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@93506 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Analysis/PathSensitive/BugReporter.h b/include/clang/Analysis/PathSensitive/BugReporter.h index 071016782a..6f6681a362 100644 --- a/include/clang/Analysis/PathSensitive/BugReporter.h +++ b/include/clang/Analysis/PathSensitive/BugReporter.h @@ -103,9 +103,9 @@ public: // BugReporter. const Stmt* getStmt() const; - const std::string& getDescription() const { return Description; } + const llvm::StringRef getDescription() const { return Description; } - const std::string& getShortDescription() const { + const llvm::StringRef getShortDescription() const { return ShortDescription.empty() ? Description : ShortDescription; } @@ -443,7 +443,7 @@ public: // FIXME: Move out-of-line (virtual function). SourceLocation getLocation() const { return L; } - void addString(const std::string& s) { Strs.push_back(s); } + void addString(llvm::StringRef s) { Strs.push_back(s); } typedef std::list::const_iterator str_iterator; str_iterator str_begin() const { return Strs.begin(); } diff --git a/lib/Analysis/BugReporter.cpp b/lib/Analysis/BugReporter.cpp index e6482698dd..13b7f4510d 100644 --- a/lib/Analysis/BugReporter.cpp +++ b/lib/Analysis/BugReporter.cpp @@ -1819,7 +1819,7 @@ void BugReporter::FlushReport(BugReportEquivClass& EQ) { Diagnostic& Diag = getDiagnostic(); FullSourceLoc L(R->getLocation(), getSourceManager()); unsigned ErrorDiag = Diag.getCustomDiagID(Diagnostic::Warning, - R->getShortDescription().c_str()); + R->getShortDescription()); switch (End-Beg) { default: assert(0 && "Don't handle this many ranges yet!");