From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Thu, 12 May 2022 04:27:24 +0000 (-0700)
Subject: gv2gml: remove 'outFile' parameter to 'emitEdge'
X-Git-Tag: 4.0.0~31^2~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8b64cf978748d77add2256f9e7c2c381c2047050;p=graphviz

gv2gml: remove 'outFile' parameter to 'emitEdge'

The only call to this function passes `outFile`, an already available global
that this parameter was shadowing. This removes numerous -Wshadow warnings.
---

diff --git a/cmd/tools/gv2gml.c b/cmd/tools/gv2gml.c
index 393b8386d..c9c706c92 100644
--- a/cmd/tools/gv2gml.c
+++ b/cmd/tools/gv2gml.c
@@ -607,11 +607,7 @@ emitEdgeAttrs (Agraph_t* G, Agedge_t* ep, FILE* outFile, int ix)
     }
 }
 
-/* emitEdge:
- */
-static void 
-emitEdge (Agraph_t* G, Agedge_t* e, FILE* outFile)
-{
+static void emitEdge(Agraph_t *G, Agedge_t *e) {
     fprintf(outFile, "  edge [\n    id %" PRIu64 "\n", (uint64_t)AGSEQ(e));
     fprintf(outFile, "    source %" PRIu64 "\n", ID(agtail(e)));
     fprintf(outFile, "    target %" PRIu64 "\n", ID(aghead(e)));
@@ -650,7 +646,7 @@ static void gv_to_gml(Agraph_t *G) {
     
     for (n = agfstnode(G); n; n = agnxtnode (G, n)) {
 	for (e = agfstout(G, n); e; e = agnxtout (G, e)) {
-	    emitEdge (G, e, outFile);
+	    emitEdge(G, e);
 	}
     }
     fprintf (outFile, "]\n");