From: Douglas Gregor Date: Mon, 22 Oct 2012 22:53:10 +0000 (+0000) Subject: Collapse ASTReader::ReadSLocEntryRecord() into its only caller, X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8b53d141ee5a91da92c4196ed7ad4142e1009d6f;p=clang Collapse ASTReader::ReadSLocEntryRecord() into its only caller, ReadSLocEntry(). No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@166447 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Serialization/ASTReader.h b/include/clang/Serialization/ASTReader.h index 500671e0b9..3b623dfe4f 100644 --- a/include/clang/Serialization/ASTReader.h +++ b/include/clang/Serialization/ASTReader.h @@ -900,7 +900,6 @@ private: bool CheckPredefinesBuffers(); bool ParseLineTable(ModuleFile &F, SmallVectorImpl &Record); bool ReadSourceManagerBlock(ModuleFile &F); - bool ReadSLocEntryRecord(int ID); llvm::BitstreamCursor &SLocCursorForID(int ID); SourceLocation getImportLocation(ModuleFile *F); bool ReadSubmoduleBlock(ModuleFile &F); diff --git a/lib/Serialization/ASTReader.cpp b/lib/Serialization/ASTReader.cpp index 6e402e1b4e..5a9eeceb46 100644 --- a/lib/Serialization/ASTReader.cpp +++ b/lib/Serialization/ASTReader.cpp @@ -1079,8 +1079,7 @@ resolveFileRelativeToOriginalDir(const std::string &Filename, return currPCHPath.str(); } -/// \brief Read in the source location entry with the given ID. -bool ASTReader::ReadSLocEntryRecord(int ID) { +bool ASTReader::ReadSLocEntry(int ID) { if (ID == 0) return false; @@ -2906,9 +2905,9 @@ ASTReader::ASTReadResult ASTReader::ReadAST(const std::string &FileName, // Preload SLocEntries. for (unsigned I = 0, N = F.PreloadSLocEntries.size(); I != N; ++I) { int Index = int(F.PreloadSLocEntries[I] - 1) + F.SLocEntryBaseID; - // Load it through the SourceManager and don't call ReadSLocEntryRecord() + // Load it through the SourceManager and don't call ReadSLocEntry() // directly because the entry may have already been loaded in which case - // calling ReadSLocEntryRecord() directly would trigger an assertion in + // calling ReadSLocEntry() directly would trigger an assertion in // SourceManager. SourceMgr.getLoadedSLocEntryByID(Index); } @@ -6009,10 +6008,6 @@ MacroID ASTReader::getGlobalMacroID(ModuleFile &M, unsigned LocalID) { return LocalID + I->second; } -bool ASTReader::ReadSLocEntry(int ID) { - return ReadSLocEntryRecord(ID); -} - serialization::SubmoduleID ASTReader::getGlobalSubmoduleID(ModuleFile &M, unsigned LocalID) { if (LocalID < NUM_PREDEF_SUBMODULE_IDS)