From: Peter Collingbourne <peter@pcc.me.uk>
Date: Sat, 23 Nov 2013 00:42:43 +0000 (+0000)
Subject: Remove uninstantiable constructor from DeclTemplate.h
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8b2dfa36eb4fbd950225b9bb9851d06462d0ae6f;p=clang

Remove uninstantiable constructor from DeclTemplate.h

Patch by Kim Gräsman!

Laszlo Nagy and me both ran into the same issue with SpecIterator from DeclTemplate.h causing an error:

tools/clang/include/clang/AST/DeclTemplate.h:560:22: error:
      no matching constructor for initialization of 'SetIteratorType' (aka
      'FoldingSetVectorIterator<clang::FunctionTemplateSpecializationInfo,
      typename SmallVector<FunctionTemplateSpecializationInfo *, 8>::iterator>')
    SpecIterator() : SetIter() {}

(see e.g. http://lists.cs.uiuc.edu/pipermail/cfe-dev/2013-November/033642.html)

The problem is the SpecIterator default constructor which needs a non-existent SetIter default constructor. SpecIterator's default constructor is evidently dead code as any call to it would fail with the above error.

This patch removes it.

Differential Revision: http://llvm-reviews.chandlerc.com/D2246

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@195526 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/AST/DeclTemplate.h b/include/clang/AST/DeclTemplate.h
index 4497197592..8fb4957b0b 100644
--- a/include/clang/AST/DeclTemplate.h
+++ b/include/clang/AST/DeclTemplate.h
@@ -564,7 +564,6 @@ protected:
     SetIteratorType SetIter;
 
   public:
-    SpecIterator() : SetIter() {}
     SpecIterator(SetIteratorType SetIter) : SetIter(SetIter) {}
 
     DeclType *operator*() const {