From: Georg Brandl <georg@python.org>
Date: Mon, 6 Oct 2014 14:21:08 +0000 (+0200)
Subject: Closes #10031: overhaul the "imports" section of the programming FAQ.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8b14dd39cfe0d0220d9505f90c5325bdaf7d2023;p=python

Closes #10031: overhaul the "imports" section of the programming FAQ.

Remove the advice to never use relative imports.
Remove the advice to locally import modules in __init__, it is a strange practice.
Remove the advice to use "from ... import *" with some modules.
---

diff --git a/Doc/c-api/type.rst b/Doc/c-api/type.rst
index 957cccf82c..68bebc8a9a 100644
--- a/Doc/c-api/type.rst
+++ b/Doc/c-api/type.rst
@@ -72,7 +72,7 @@ Type Objects
    .. versionadded:: 2.2
 
    This function only checks for actual subtypes, which means that
-   :meth:`~type.__subclasscheck__` is not called on *b*.  Call
+   :meth:`~class.__subclasscheck__` is not called on *b*.  Call
    :c:func:`PyObject_IsSubclass` to do the same check that :func:`issubclass`
    would do.
 
diff --git a/Doc/faq/programming.rst b/Doc/faq/programming.rst
index 1a883d0e04..f0dcdb58e7 100644
--- a/Doc/faq/programming.rst
+++ b/Doc/faq/programming.rst
@@ -438,9 +438,8 @@ What are the "best practices" for using import in a module?
 -----------------------------------------------------------
 
 In general, don't use ``from modulename import *``.  Doing so clutters the
-importer's namespace.  Some people avoid this idiom even with the few modules
-that were designed to be imported in this manner.  Modules designed in this
-manner include :mod:`Tkinter`, and :mod:`threading`.
+importer's namespace, and makes it much harder for linters to detect undefined
+names.
 
 Import modules at the top of a file.  Doing so makes it clear what other modules
 your code requires and avoids questions of whether the module name is in scope.
@@ -454,11 +453,10 @@ It's good practice if you import modules in the following order:
    directory) -- e.g. mx.DateTime, ZODB, PIL.Image, etc.
 3. locally-developed modules
 
-Never use relative package imports.  If you're writing code that's in the
-``package.sub.m1`` module and want to import ``package.sub.m2``, do not just
+Only use explicit relative package imports.  If you're writing code that's in
+the ``package.sub.m1`` module and want to import ``package.sub.m2``, do not just
 write ``import m2``, even though it's legal.  Write ``from package.sub import
-m2`` instead.  Relative imports can lead to a module being initialized twice,
-leading to confusing bugs.  See :pep:`328` for details.
+m2`` or ``from . import m2`` instead.
 
 It is sometimes necessary to move imports to a function or class to avoid
 problems with circular imports.  Gordon McMillan says:
@@ -490,14 +488,6 @@ module, but loading a module multiple times is virtually free, costing only a
 couple of dictionary lookups.  Even if the module name has gone out of scope,
 the module is probably available in :data:`sys.modules`.
 
-If only instances of a specific class use a module, then it is reasonable to
-import the module in the class's ``__init__`` method and then assign the module
-to an instance variable so that the module is always available (via that
-instance variable) during the life of the object.  Note that to delay an import
-until the class is instantiated, the import must be inside a method.  Putting
-the import inside the class but outside of any method still causes the import to
-occur when the module is initialized.
-
 
 Why are default values shared between objects?
 ----------------------------------------------