From: Holger Weiss <holger@zedat.fu-berlin.de>
Date: Wed, 18 Jul 2018 16:16:42 +0000 (+0200)
Subject: mod_http_upload: Deprecate 'service_url' option
X-Git-Tag: 18.09~84
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8ad6afd652bdc6b3d582df3981770507b897b19f;p=ejabberd

mod_http_upload: Deprecate 'service_url' option

Users should migrate to the 'external_secret' interface.
---

diff --git a/src/mod_http_upload.erl b/src/mod_http_upload.erl
index 8ed47f69d..ed29299f6 100644
--- a/src/mod_http_upload.erl
+++ b/src/mod_http_upload.erl
@@ -183,7 +183,10 @@ mod_opt_type(get_url) ->
     end;
 mod_opt_type(service_url) ->
     fun(undefined) -> undefined;
-       (URL) -> misc:try_url(URL)
+       (URL) ->
+	   ?WARNING_MSG("option 'service_url' is deprecated, consider unsing "
+	                "the 'external_secret' interface instead", []),
+	   misc:try_url(URL)
     end;
 mod_opt_type(custom_headers) ->
     fun(Headers) ->