From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Mon, 10 Oct 2022 15:22:47 +0000 (-0700)
Subject: smyrna mTestgvpr: remove unnecessary dynamic allocation
X-Git-Tag: 7.0.0~8^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8ab0b550fc77b926ec4b4a14367d379bf4a2df5d;p=graphviz

smyrna mTestgvpr: remove unnecessary dynamic allocation

This is the equivalent of e18e57257e968545ff9d130a3b9b7bdd440deb1c applied to
similar code.
---

diff --git a/cmd/smyrna/gui/menucallbacks.c b/cmd/smyrna/gui/menucallbacks.c
index d8c5fd273..395d425ff 100644
--- a/cmd/smyrna/gui/menucallbacks.c
+++ b/cmd/smyrna/gui/menucallbacks.c
@@ -8,7 +8,6 @@
  * Contributors: Details at https://graphviz.org
  *************************************************************************/
 
-#include <cgraph/alloc.h>
 #include "menucallbacks.h"
 #include "viewport.h"
 #include "tvnodes.h"
@@ -286,7 +285,6 @@ void mTestgvpr(GtkWidget * widget, gpointer user_data)
     GtkTextIter endit;
     const char *args;
     int cloneGraph;
-    char **argv;
 
     args =
 	gtk_entry_get_text((GtkEntry *)
@@ -315,7 +313,8 @@ void mTestgvpr(GtkWidget * widget, gpointer user_data)
 	argc++;
     } else
 	cloneGraph = 0;
-    argv = gv_calloc(argc + 1, sizeof(char*));
+    assert(argc <= 5);
+    char *argv[6] = {0};
     size_t j = 0;
     argv[j++] = "smyrna";
     if (cloneGraph)
@@ -339,7 +338,6 @@ void mTestgvpr(GtkWidget * widget, gpointer user_data)
     assert(j == argc);
 
     run_gvpr(view->g[view->activeGraph], argc, argv);
-    free(argv);
     g_free(bf2);
 }