From: Daniel Jasper Date: Wed, 14 Jan 2015 09:51:32 +0000 (+0000) Subject: clang-format: [Java] Don't line-wrap before annotations' l_parens. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=89fc46ad711ab2127a690b28a7ad26491c271eeb;p=clang clang-format: [Java] Don't line-wrap before annotations' l_parens. Before: @SomeAnnotation (aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa) int i; After: @SomeAnnotation( aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa) int i; git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@225963 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Format/TokenAnnotator.cpp b/lib/Format/TokenAnnotator.cpp index 11dd2be619..351c6fa9e8 100644 --- a/lib/Format/TokenAnnotator.cpp +++ b/lib/Format/TokenAnnotator.cpp @@ -1939,7 +1939,7 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line, if (Left.Tok.getObjCKeywordID() == tok::objc_interface) return false; if (Left.isOneOf(TT_JavaAnnotation, TT_LeadingJavaAnnotation)) - return true; + return !Right.is(tok::l_paren); if (Right.isOneOf(TT_StartOfName, TT_FunctionDeclarationName) || Right.is(tok::kw_operator)) return true; diff --git a/unittests/Format/FormatTestJava.cpp b/unittests/Format/FormatTestJava.cpp index a3e86d6f65..39abc7b555 100644 --- a/unittests/Format/FormatTestJava.cpp +++ b/unittests/Format/FormatTestJava.cpp @@ -279,6 +279,10 @@ TEST_F(FormatTestJava, Annotations) { verifyFormat("@Test(a)\n" "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);"); + verifyFormat("@SomeAnnotation(\n" + " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)\n" + "int i;", + getStyleWithColumns(50)); } TEST_F(FormatTestJava, Generics) {