From: Benjamin Peterson <benjamin@python.org>
Date: Tue, 8 May 2012 13:22:24 +0000 (-0400)
Subject: fix possible refleak (closes #14752)
X-Git-Tag: v3.3.0a4~226^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=89a6e9a27b565d8143c3e064aae92e831ff14801;p=python

fix possible refleak (closes #14752)
---

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 13a20f7905..9430d3959c 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -3527,6 +3527,7 @@ add_methods(PyTypeObject *type, PyMethodDef *meth)
 
     for (; meth->ml_name != NULL; meth++) {
         PyObject *descr;
+        int err;
         if (PyDict_GetItemString(dict, meth->ml_name) &&
             !(meth->ml_flags & METH_COEXIST))
                 continue;
@@ -3550,9 +3551,10 @@ add_methods(PyTypeObject *type, PyMethodDef *meth)
         }
         if (descr == NULL)
             return -1;
-        if (PyDict_SetItemString(dict, meth->ml_name, descr) < 0)
-            return -1;
+        err = PyDict_SetItemString(dict, meth->ml_name, descr);
         Py_DECREF(descr);
+        if (err < 0)
+            return -1;
     }
     return 0;
 }