From: Steph Fox Date: Sun, 24 Feb 2008 19:34:05 +0000 (+0000) Subject: Updating tests. 100% pass rate here now - not sure about the rest of the world just... X-Git-Tag: RELEASE_2_0_0a1~344 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=89842172e35ee887ecc009722275b3f1aca1f987;p=php Updating tests. 100% pass rate here now - not sure about the rest of the world just yet (sorry Marcus). --- diff --git a/ext/phar/tests/phar_convert_tar.phpt b/ext/phar/tests/phar_convert_tar.phpt index 810acfc113..dc5db0c7af 100644 --- a/ext/phar/tests/phar_convert_tar.phpt +++ b/ext/phar/tests/phar_convert_tar.phpt @@ -8,10 +8,10 @@ phar.readonly=0 --FILE-- '; $file = $stub; @@ -30,9 +30,9 @@ $phar->convertToTar(); var_dump($phar->isTar()); var_dump($phar->getStub()); -copy($fname, $fname2); +copy($fname2, $fname3); -$phar = new Phar($fname2); +$phar = new Phar($fname3); var_dump($phar->isTar()); var_dump($phar->getStub()); @@ -40,8 +40,8 @@ var_dump($phar->getStub()); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/phar_convert_tar2.phpt b/ext/phar/tests/phar_convert_tar2.phpt index fd6b9002c9..db26aae0f0 100644 --- a/ext/phar/tests/phar_convert_tar2.phpt +++ b/ext/phar/tests/phar_convert_tar2.phpt @@ -11,8 +11,8 @@ phar.readonly=0 $fname = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar.php'; $pname = 'phar://' . $fname; -$fname2 = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.2.phar.php'; -$pname2 = 'phar://' . $fname; +$fname2 = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar.tar'; +$fname3 = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.2.phar.tar'; $stub = ''; $file = $stub; @@ -33,9 +33,9 @@ var_dump($phar->isTar()); var_dump($phar->isCompressed()); var_dump($phar->getStub()); -copy($fname, $fname2); +copy($fname2, $fname3); -$phar = new Phar($fname2); +$phar = new Phar($fname3); var_dump($phar->isTar()); var_dump($phar->isCompressed() == Phar::GZ); var_dump($phar->getStub()); @@ -44,8 +44,8 @@ var_dump($phar->getStub()); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/phar_convert_tar3.phpt b/ext/phar/tests/phar_convert_tar3.phpt index 3ea2556bf6..60885075da 100644 --- a/ext/phar/tests/phar_convert_tar3.phpt +++ b/ext/phar/tests/phar_convert_tar3.phpt @@ -11,8 +11,8 @@ phar.readonly=0 $fname = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar.php'; $pname = 'phar://' . $fname; -$fname2 = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.2.phar.php'; -$pname2 = 'phar://' . $fname; +$fname2 = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar.tar'; +$fname3 = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.2.phar.tar'; $stub = ''; $file = $stub; @@ -33,9 +33,9 @@ var_dump($phar->isTar()); var_dump($phar->isCompressed()); var_dump($phar->getStub()); -copy($fname, $fname2); +copy($fname2, $fname3); -$phar = new Phar($fname2); +$phar = new Phar($fname3); var_dump($phar->isTar()); var_dump($phar->isCompressed() == Phar::BZ2); var_dump($phar->getStub()); @@ -44,8 +44,8 @@ var_dump($phar->getStub()); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/phar_convert_zip.phpt b/ext/phar/tests/phar_convert_zip.phpt index 9853174941..f99bda2d17 100644 --- a/ext/phar/tests/phar_convert_zip.phpt +++ b/ext/phar/tests/phar_convert_zip.phpt @@ -8,10 +8,10 @@ phar.readonly=0 --FILE-- '; $file = $stub; @@ -30,9 +30,9 @@ $phar->convertToZip(); var_dump($phar->isZip()); var_dump($phar->getStub()); -copy($fname, $fname2); +copy($fname2, $fname3); -$phar = new Phar($fname2); +$phar = new Phar($fname3); var_dump($phar->isZip()); var_dump($phar->getStub()); @@ -40,8 +40,8 @@ var_dump($phar->getStub()); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/refcount1_5_2.phpt b/ext/phar/tests/refcount1_5_2.phpt index 78a626371d..bf2c2b76b3 100755 --- a/ext/phar/tests/refcount1_5_2.phpt +++ b/ext/phar/tests/refcount1_5_2.phpt @@ -3,42 +3,52 @@ Phar: test that refcounting avoids problems with deleting a file --SKIPIF-- -")) die("skip requires 5.2 or earlier"); ?> +")) die("skip requires 5.2 or earlier"); ?> --INI-- phar.readonly=0 phar.require_hash=0 --FILE-- "; + +$fname = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar'; +$alias = 'phar://' . $fname; + +$phar = new Phar($fname); +$phar->setStub(""); +$phar->setAlias('hio'); $files = array(); + $files['a.php'] = ''; $files['b.php'] = ''; $files['b/c.php'] = ''; -include 'files/phar_test.inc'; -$fp = fopen($pname . '/b/c.php', 'wb'); +foreach ($files as $n => $file) { + $phar[$n] = $file; +} +$phar->stopBuffering(); + +$fp = fopen($alias . '/b/c.php', 'wb'); fwrite($fp, "extra"); fclose($fp); + echo "===CLOSE===\n"; -$p = new Phar($fname); -$b = fopen($pname . '/b/c.php', 'rb'); -$a = $p['b/c.php']; + +$b = fopen($alias . '/b/c.php', 'rb'); +$a = $phar['b/c.php']; var_dump($a); var_dump(fread($b, 20)); rewind($b); echo "===UNLINK===\n"; -unlink($pname . '/b/c.php'); +unlink($alias . '/b/c.php'); var_dump($a); var_dump(fread($b, 20)); -include $pname . '/b/c.php'; +include $alias . '/b/c.php'; ?> ===DONE=== --CLEAN-- - + --EXPECTF-- ===CLOSE=== object(PharFileInfo)#%d (0) { @@ -46,7 +56,7 @@ object(PharFileInfo)#%d (0) { string(5) "extra" ===UNLINK=== -Warning: unlink(): phar error: "b/c.php" in phar "%sefcount1.phar.php", has open file pointers, cannot unlink in %sefcount1.php on line %d +Warning: unlink(): phar error: "b/c.php" in phar "%sefcount1_5_2.phar", has open file pointers, cannot unlink in %sefcount1_5_2.php on line %d object(PharFileInfo)#%d (0) { } string(5) "extra" diff --git a/ext/phar/tests/tar/phar_convert_phar.phpt b/ext/phar/tests/tar/phar_convert_phar.phpt index 4c588720de..92e755bd30 100644 --- a/ext/phar/tests/tar/phar_convert_phar.phpt +++ b/ext/phar/tests/tar/phar_convert_phar.phpt @@ -8,10 +8,8 @@ phar.readonly=0 --FILE-- stopBuffering(); @@ -38,8 +36,8 @@ var_dump(strlen($phar->getStub())); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/tar/phar_convert_phar2.phpt b/ext/phar/tests/tar/phar_convert_phar2.phpt index b744188e9a..0c1998c565 100644 --- a/ext/phar/tests/tar/phar_convert_phar2.phpt +++ b/ext/phar/tests/tar/phar_convert_phar2.phpt @@ -9,10 +9,8 @@ phar.readonly=0 --FILE-- stopBuffering(); @@ -41,8 +39,8 @@ var_dump(strlen($phar->getStub())); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/tar/phar_convert_phar3.phpt b/ext/phar/tests/tar/phar_convert_phar3.phpt index 0a99bca3c8..1194da86e7 100644 --- a/ext/phar/tests/tar/phar_convert_phar3.phpt +++ b/ext/phar/tests/tar/phar_convert_phar3.phpt @@ -9,10 +9,8 @@ phar.readonly=0 --FILE-- stopBuffering(); @@ -41,8 +39,8 @@ var_dump(strlen($phar->getStub())); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/tar/refcount1_5_2.phpt b/ext/phar/tests/tar/refcount1_5_2.phpt index f0e52ca2d9..18587d91ad 100755 --- a/ext/phar/tests/tar/refcount1_5_2.phpt +++ b/ext/phar/tests/tar/refcount1_5_2.phpt @@ -3,50 +3,52 @@ Phar: test that refcounting avoids problems with deleting a file tar-based --SKIPIF-- -")) die("skip requires 5.2 or earlier"); ?> +")) die("skip requires 5.2 or earlier"); ?> --INI-- phar.readonly=0 phar.require_hash=0 --FILE-- init(); -$a->addFile('.phar/stub.php', ""); +$fname = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar.tar'; +$alias = 'phar://' . $fname; + +$phar = new Phar($fname); +$phar->setStub(""); +$phar->setAlias('hio'); $files = array(); + $files['a.php'] = ''; $files['b.php'] = ''; $files['b/c.php'] = ''; -$files['.phar/alias.txt'] = 'hio'; + foreach ($files as $n => $file) { -$a->addFile($n, $file); + $phar[$n] = $file; } -$a->close(); +$phar->stopBuffering(); -$fp = fopen($pname . '/b/c.php', 'wb'); +$fp = fopen($alias . '/b/c.php', 'wb'); fwrite($fp, "extra"); fclose($fp); + echo "===CLOSE===\n"; -$p = new Phar($fname); -$b = fopen($pname . '/b/c.php', 'rb'); -$a = $p['b/c.php']; + +$b = fopen($alias . '/b/c.php', 'rb'); +$a = $phar['b/c.php']; var_dump($a); var_dump(fread($b, 20)); rewind($b); echo "===UNLINK===\n"; -unlink($pname . '/b/c.php'); +unlink($alias . '/b/c.php'); var_dump($a); var_dump(fread($b, 20)); -include $pname . '/b/c.php'; +include $alias . '/b/c.php'; ?> ===DONE=== --CLEAN-- - + --EXPECTF-- ===CLOSE=== object(PharFileInfo)#%d (0) { @@ -54,7 +56,7 @@ object(PharFileInfo)#%d (0) { string(5) "extra" ===UNLINK=== -Warning: unlink(): phar error: "b/c.php" in phar "%sefcount1.phar.php", has open file pointers, cannot unlink in %sefcount1.php on line %d +Warning: unlink(): phar error: "b/c.php" in phar "%sefcount1_5_2.phar.tar", has open file pointers, cannot unlink in %sefcount1_5_2.php on line %d object(PharFileInfo)#%d (0) { } string(5) "extra" diff --git a/ext/phar/tests/zip/phar_convert_phar.phpt b/ext/phar/tests/zip/phar_convert_phar.phpt index cd33bdd91e..bf596c3a02 100644 --- a/ext/phar/tests/zip/phar_convert_phar.phpt +++ b/ext/phar/tests/zip/phar_convert_phar.phpt @@ -8,10 +8,8 @@ phar.readonly=0 --FILE-- stopBuffering(); @@ -38,8 +36,8 @@ var_dump(strlen($phar->getStub())); ===DONE=== --CLEAN-- --EXPECT-- diff --git a/ext/phar/tests/zip/refcount1_5_2.phpt b/ext/phar/tests/zip/refcount1_5_2.phpt index 4514dc6dc4..f3b2771f44 100755 --- a/ext/phar/tests/zip/refcount1_5_2.phpt +++ b/ext/phar/tests/zip/refcount1_5_2.phpt @@ -3,50 +3,52 @@ Phar: test that refcounting avoids problems with deleting a file zip-based --SKIPIF-- -")) die("skip requires 5.2 or earlier"); ?> +")) die("skip requires 5.2 or earlier"); ?> --INI-- phar.readonly=0 phar.require_hash=0 --FILE-- init(); -$a->addFile('.phar/stub.php', ""); +$fname = dirname(__FILE__) . '/' . basename(__FILE__, '.php') . '.phar.zip'; +$alias = 'phar://' . $fname; + +$phar = new Phar($fname); +$phar->setStub(""); +$phar->setAlias('hio'); $files = array(); + $files['a.php'] = ''; $files['b.php'] = ''; $files['b/c.php'] = ''; -$files['.phar/alias.txt'] = 'hio'; + foreach ($files as $n => $file) { -$a->addFile($n, $file); + $phar[$n] = $file; } -$a->close(); +$phar->stopBuffering(); -$fp = fopen($pname . '/b/c.php', 'wb'); +$fp = fopen($alias . '/b/c.php', 'wb'); fwrite($fp, "extra"); fclose($fp); + echo "===CLOSE===\n"; -$p = new Phar($fname); -$b = fopen($pname . '/b/c.php', 'rb'); -$a = $p['b/c.php']; + +$b = fopen($alias . '/b/c.php', 'rb'); +$a = $phar['b/c.php']; var_dump($a); var_dump(fread($b, 20)); rewind($b); echo "===UNLINK===\n"; -unlink($pname . '/b/c.php'); +unlink($alias . '/b/c.php'); var_dump($a); var_dump(fread($b, 20)); -include $pname . '/b/c.php'; +include $alias . '/b/c.php'; ?> ===DONE=== --CLEAN-- - + --EXPECTF-- ===CLOSE=== object(PharFileInfo)#%d (0) { @@ -54,7 +56,7 @@ object(PharFileInfo)#%d (0) { string(5) "extra" ===UNLINK=== -Warning: unlink(): phar error: "b/c.php" in phar "%sefcount1.phar.php", has open file pointers, cannot unlink in %sefcount1.php on line %d +Warning: unlink(): phar error: "b/c.php" in phar "%sefcount1_5_2.phar.zip", has open file pointers, cannot unlink in %sefcount1_5_2.php on line %d object(PharFileInfo)#%d (0) { } string(5) "extra"