From: Matteo Beccati Date: Sat, 28 Mar 2009 03:12:52 +0000 (+0000) Subject: MFH: X-Git-Tag: php-5.3.0RC2~262 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=89741745326a873e2057240735b56f2496f94d65;p=php MFH: - Reverting: pcntl_signal() returning NULL when passing wrong parameters --- diff --git a/ext/pcntl/pcntl.c b/ext/pcntl/pcntl.c index 8dfcd6cba4..91fcea3738 100755 --- a/ext/pcntl/pcntl.c +++ b/ext/pcntl/pcntl.c @@ -757,7 +757,7 @@ PHP_FUNCTION(pcntl_signal) zend_bool restart_syscalls = 1; if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "lz|b", &signo, &handle, &restart_syscalls) == FAILURE) { - RETURN_FALSE; + return; } if (!PCNTL_G(spares)) { diff --git a/ext/pcntl/tests/pcntl_signal.phpt b/ext/pcntl/tests/pcntl_signal.phpt index 324cc0b418..977f26fbcc 100644 --- a/ext/pcntl/tests/pcntl_signal.phpt +++ b/ext/pcntl/tests/pcntl_signal.phpt @@ -25,7 +25,7 @@ echo "ok\n"; signal dispatched Warning: pcntl_signal() expects at least 2 parameters, 0 given in %s -bool(false) +NULL bool(true) Warning: pcntl_signal(): Invalid value for handle argument specified in %s