From: Marcel Raad <raad@teamviewer.com>
Date: Sun, 4 Jun 2017 14:46:03 +0000 (+0200)
Subject: curl_ntlm_core: pass unsigned char to toupper
X-Git-Tag: curl-7_54_1~31
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=892c5e4cb3af997c232e323b8831af6e8637a84d;p=curl

curl_ntlm_core: pass unsigned char to toupper

Otherwise, clang on Cygwin64 warns:
curl_ntlm_core.c:525:35: error: array subscript is of type 'char'
[-Werror,-Wchar-subscripts]
    dest[2 * i] = (unsigned char)(toupper(src[i]));
                                  ^~~~~~~~~~~~~~~
/usr/include/ctype.h:152:25: note: expanded from macro 'toupper'
      (void) __CTYPE_PTR[__x]; (toupper) (__x);})
                        ^~~~
---

diff --git a/lib/curl_ntlm_core.c b/lib/curl_ntlm_core.c
index b15215b2f..25f2a3ad4 100644
--- a/lib/curl_ntlm_core.c
+++ b/lib/curl_ntlm_core.c
@@ -522,7 +522,7 @@ static void ascii_uppercase_to_unicode_le(unsigned char *dest,
 {
   size_t i;
   for(i = 0; i < srclen; i++) {
-    dest[2 * i] = (unsigned char)(toupper(src[i]));
+    dest[2 * i] = (unsigned char)(toupper((unsigned char)src[i]));
     dest[2 * i + 1] = '\0';
   }
 }