From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sun, 18 Mar 2012 03:13:14 +0000 (+0100)
Subject: Remove unused version of sys_lseek
X-Git-Tag: v4.7~64
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=88c63f21b18bcf345856c5ef2ca9504f29e9ace8;p=strace

Remove unused version of sys_lseek

It is buggy: it returns RVAL_LUDECIMAL, which means the return value
is in tcp->u_lrval. But tcp->u_lrval is never set
(on Linux - it used to be set on other OSes).

* file.c (sys_lseek): Remove a version of this function which is
supposed to be used if off_t is long long. It appears to be buggy
and unused.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---

diff --git a/file.c b/file.c
index 258528e1..32d21229 100644
--- a/file.c
+++ b/file.c
@@ -520,25 +520,6 @@ sys_lseek(struct tcb *tcp)
 	return RVAL_UDECIMAL;
 }
 # endif
-#else /* HAVE_LONG_LONG_OFF_T */
-/*
- * ??? Any arch using it? I386 doesn't...
- */
-int
-sys_lseek(struct tcb *tcp)
-{
-	if (entering(tcp)) {
-		int argn;
-		printfd(tcp, tcp->u_arg[0]);
-		tprints(", ");
-		if (tcp->u_arg[3] == SEEK_SET)
-			argn = printllval(tcp, "%llu, ", 1);
-		else
-			argn = printllval(tcp, "%lld, ", 1);
-		printxval(whence, tcp->u_arg[argn], "SEEK_???");
-	}
-	return RVAL_LUDECIMAL;
-}
 #endif
 
 int