From: Alexander Barton <alex@barton.de>
Date: Wed, 28 Mar 2012 09:30:48 +0000 (+0200)
Subject: Don't ignore "permission denied" errors when enabling chroot
X-Git-Tag: rel-19.2-rc1~28
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=88c3d4896af6c09de5d360d93ad8b02793aeb234;p=ngircd

Don't ignore "permission denied" errors when enabling chroot

Up to now, ngIRCd silently ignored permission denied errors when trying
to enable a chroot setup: only the "not running chrooted" message became
logged later on.

This patch lets ngIRCd exit with a fatal error when the chroot can't
be enabled on startup -- this is the much safer bevahiour!
---

diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c
index 60d15a1f..f28ff05b 100644
--- a/src/ngircd/ngircd.c
+++ b/src/ngircd/ngircd.c
@@ -642,12 +642,10 @@ NGIRCd_Init(bool NGIRCd_NoDaemon)
 		}
 
 		if (chroot(Conf_Chroot) != 0) {
-			if (errno != EPERM) {
-				Log(LOG_ERR,
-				    "Can't change root directory to \"%s\": %s",
-				    Conf_Chroot, strerror(errno));
-				goto out;
-			}
+			Log(LOG_ERR,
+			    "Can't change root directory to \"%s\": %s",
+			    Conf_Chroot, strerror(errno));
+			goto out;
 		} else {
 			chrooted = true;
 			Log(LOG_INFO,