From: Bruce Momjian <bruce@momjian.us>
Date: Sat, 26 Jan 2013 19:51:59 +0000 (-0500)
Subject: Update comments in new DROP IF EXISTS code; commit message update
X-Git-Tag: REL9_3_BETA1~417
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8865fe0ad3e4260db0e67e2064200d96c0999fa0;p=postgresql

Update comments in new DROP IF EXISTS code; commit message update

DROP IF EXISTS with a missing schema in commit
7e2322dff30c04d90c0602d2b5ae24b4881db88b applies not only to tables, but
to DROP IF EXISTS with missing schemas for indexes, views, sequences,
and foreign tables.  Yeah!
---

diff --git a/src/backend/catalog/namespace.c b/src/backend/catalog/namespace.c
index 6964feedc2..07a8761709 100644
--- a/src/backend/catalog/namespace.c
+++ b/src/backend/catalog/namespace.c
@@ -217,8 +217,8 @@ Datum		pg_is_other_temp_schema(PG_FUNCTION_ARGS);
  *		Given a RangeVar describing an existing relation,
  *		select the proper namespace and look up the relation OID.
  *
- * If the relation is not found, return InvalidOid if missing_ok = true,
- * otherwise raise an error.
+ * If the schema or relation is not found, return InvalidOid if missing_ok
+ * = true, otherwise raise an error.
  *
  * If nowait = true, throw an error if we'd have to wait for a lock.
  *
@@ -293,8 +293,8 @@ RangeVarGetRelidExtended(const RangeVar *relation, LOCKMODE lockmode,
 
 					namespaceId = LookupExplicitNamespace(relation->schemaname, missing_ok);
 					/*
-					 *	For missing_ok, allow a non-existant schema name
-					 *	to throw the error below (namespaceId == InvalidOid).
+					 *	For missing_ok, allow a non-existant schema name to
+					 *	return InvalidOid.
 					 */
 					if (namespaceId != myTempNamespace)
 						ereport(ERROR,