From: Yossi Gottlieb <yossigo@gmail.com>
Date: Tue, 17 Nov 2015 10:18:34 +0000 (+0200)
Subject: Gracefully handle cases where IPv6 (AF_INET6) is not supported.
X-Git-Tag: dnsdist-1.0.0-alpha1~197^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=883ad072c03279bfd0637e96f5fae488343b8d8a;p=pdns

Gracefully handle cases where IPv6 (AF_INET6) is not supported.

This fixes issue #1259 and allows a single configuration file to be used
both for IPv6 enabled and IPv6-less systems.
---

diff --git a/pdns/nameserver.cc b/pdns/nameserver.cc
index c5539af22..b068b9936 100644
--- a/pdns/nameserver.cc
+++ b/pdns/nameserver.cc
@@ -206,8 +206,13 @@ void UDPNameserver::bindIPv6()
 
     s=socket(AF_INET6,SOCK_DGRAM,0);
     if(s<0) {
-      L<<Logger::Error<<"Unable to acquire UDPv6 socket: "+string(strerror(errno)) << endl;
-      throw PDNSException("Unable to acquire UDPv6 socket: "+string(strerror(errno)));
+      if( errno == EAFNOSUPPORT ) {
+        L<<Logger::Error<<"IPv6 Address Family is not supported - skipping UDPv6 bind" << endl;
+        return;
+      } else {
+        L<<Logger::Error<<"Unable to acquire a UDPv6 socket: "+string(strerror(errno)) << endl;
+        throw PDNSException("Unable to acquire a UDPv6 socket: "+string(strerror(errno)));
+      }
     }
 
     setCloseOnExec(s);
diff --git a/pdns/resolver.cc b/pdns/resolver.cc
index b969fa39d..83eebb328 100644
--- a/pdns/resolver.cc
+++ b/pdns/resolver.cc
@@ -56,11 +56,14 @@ int makeQuerySocket(const ComboAddress& local, bool udpOrTCP)
   ComboAddress ourLocal(local);
   
   int sock=socket(ourLocal.sin4.sin_family, udpOrTCP ? SOCK_DGRAM : SOCK_STREAM, 0);
-  setCloseOnExec(sock);
   if(sock < 0) {
-    unixDie("Creating local resolver socket for "+ourLocal.toString() + ((local.sin4.sin_family == AF_INET6) ? ", does your OS miss IPv6?" : ""));
+    if(errno == EAFNOSUPPORT && local.sin4.sin_family == AF_INET6) {
+        return sock;
+    }
+    unixDie("Creating local resolver socket for "+ourLocal.toString());
   }
 
+  setCloseOnExec(sock);
   if(udpOrTCP) {
     // udp, try hard to bind an unpredictable port
     int tries=10;