From: Nikita Popov Date: Wed, 19 Jun 2019 15:25:20 +0000 (+0200) Subject: Avoid signed shift ub in php_sdl X-Git-Tag: php-7.4.0alpha2~47 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8743d5e99acd59504bdf34e65d2ba25f20d76970;p=php Avoid signed shift ub in php_sdl --- diff --git a/ext/soap/php_sdl.c b/ext/soap/php_sdl.c index de4bf5c328..510d03c551 100644 --- a/ext/soap/php_sdl.c +++ b/ext/soap/php_sdl.c @@ -1178,7 +1178,7 @@ static sdlPtr load_wsdl(zval *this_ptr, char *struri) #define WSDL_CACHE_VERSION 0x10 #define WSDL_CACHE_GET(ret,type,buf) memcpy(&ret,*buf,sizeof(type)); *buf += sizeof(type); -#define WSDL_CACHE_GET_INT(ret,buf) ret = ((unsigned char)(*buf)[0])|((unsigned char)(*buf)[1]<<8)|((unsigned char)(*buf)[2]<<16)|((int)(*buf)[3]<<24); *buf += 4; +#define WSDL_CACHE_GET_INT(ret,buf) ret = ((unsigned char)(*buf)[0])|((unsigned char)(*buf)[1]<<8)|((unsigned char)(*buf)[2]<<16)|((unsigned)(*buf)[3]<<24); *buf += 4; #define WSDL_CACHE_GET_1(ret,type,buf) ret = (type)(**buf); (*buf)++; #define WSDL_CACHE_GET_N(ret,n,buf) memcpy(ret,*buf,n); *buf += n; #define WSDL_CACHE_SKIP(n,buf) *buf += n;