From: Anders Carlsson <andersca@mac.com>
Date: Wed, 3 Nov 2010 02:22:29 +0000 (+0000)
Subject: A number in an input constraint can't point to a read-write ('+') constraint. Fixes... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=86eda39c8af47280273758debf0432933bdeee3c;p=clang

A number in an input constraint can't point to a read-write ('+') constraint. Fixes PR3904.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@118145 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Basic/TargetInfo.cpp b/lib/Basic/TargetInfo.cpp
index 6ef306d27e..947cbfc3f6 100644
--- a/lib/Basic/TargetInfo.cpp
+++ b/lib/Basic/TargetInfo.cpp
@@ -350,6 +350,10 @@ bool TargetInfo::validateInputConstraint(ConstraintInfo *OutputConstraints,
         if (i >= NumOutputs)
           return false;
 
+        // A number must refer to an output only operand.
+        if (OutputConstraints[i].isReadWrite())
+          return false;
+
         // The constraint should have the same info as the respective
         // output constraint.
         Info.setTiedOperand(i, OutputConstraints[i]);
diff --git a/test/Sema/asm.c b/test/Sema/asm.c
index 52611faf3d..73d081ddd3 100644
--- a/test/Sema/asm.c
+++ b/test/Sema/asm.c
@@ -79,3 +79,9 @@ int test7(unsigned long long b) {
 
 // <rdar://problem/7574870>
 asm volatile (""); // expected-warning {{meaningless 'volatile' on asm outside function}}
+
+// PR3904
+int test8(int i) {
+  // A number in an input constraint can't point to a read-write constraint.
+  asm ("" : "+r" (i), "=r"(i) :  "0" (i)); // expected-error{{invalid input constraint '0' in asm}}
+}