From: Andy Polyakov <appro@openssl.org>
Date: Wed, 20 May 2015 07:24:36 +0000 (+0200)
Subject: bn/bn_gf2m.c: appease STACK, unstable code detector.
X-Git-Tag: OpenSSL_1_1_0-pre1~1089
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=86e5d1e32b2d702a5fc777e612cd746e790098ef;p=openssl

bn/bn_gf2m.c: appease STACK, unstable code detector.

RT#3852

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/bn/bn_gf2m.c b/crypto/bn/bn_gf2m.c
index caad2d0d0d..73e1e8f11b 100644
--- a/crypto/bn/bn_gf2m.c
+++ b/crypto/bn/bn_gf2m.c
@@ -450,8 +450,7 @@ int BN_GF2m_mod_arr(BIGNUM *r, const BIGNUM *a, const int p[])
             d0 = p[k] % BN_BITS2;
             d1 = BN_BITS2 - d0;
             z[n] ^= (zz << d0);
-            tmp_ulong = zz >> d1;
-            if (d0 && tmp_ulong)
+            if (d0 && (tmp_ulong = zz >> d1))
                 z[n + 1] ^= tmp_ulong;
         }