From: Victor Stinner Date: Fri, 1 Sep 2017 22:26:17 +0000 (+0200) Subject: bpo-31323: Fix reference leak in test_ssl (#3263) X-Git-Tag: v3.7.0a1~192 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=868710158910fa38e285ce0e6d50026e1d0b2a8c;p=python bpo-31323: Fix reference leak in test_ssl (#3263) Store exceptions as string rather than object to prevent reference cycles which cause leaking dangling threads. --- diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py index 104b7f377a..5e143f95e3 100644 --- a/Lib/test/test_ssl.py +++ b/Lib/test/test_ssl.py @@ -1889,7 +1889,11 @@ if _have_threads: # XXX Various errors can have happened here, for example # a mismatching protocol version, an invalid certificate, # or a low-level bug. This should be made more discriminating. - self.server.conn_errors.append(e) + # + # bpo-31323: Store the exception as string to prevent + # a reference leak: server -> conn_errors -> exception + # -> traceback -> self (ConnectionHandler) -> server + self.server.conn_errors.append(str(e)) if self.server.chatty: handle_error("\n server: bad connection attempt from " + repr(self.addr) + ":\n") self.running = False @@ -3097,7 +3101,7 @@ if _have_threads: with context.wrap_socket(socket.socket()) as s: with self.assertRaises(OSError): s.connect((HOST, server.port)) - self.assertIn("no shared cipher", str(server.conn_errors[0])) + self.assertIn("no shared cipher", server.conn_errors[0]) def test_version_basic(self): """