From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Thu, 19 Apr 2018 20:20:29 +0000 (+0200)
Subject: Fix a gcc-8 warning -Wcast-function-type
X-Git-Tag: OpenSSL_1_1_0i~170
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=867dc5441aab7c813136e996d5d437740e6a3c18;p=openssl

Fix a gcc-8 warning -Wcast-function-type

Casting to the generic function type "void (*)(void)"
prevents the warning.

Backport of #5816

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6027)
---

diff --git a/test/shlibloadtest.c b/test/shlibloadtest.c
index 919bf7c5f0..d584413ac9 100644
--- a/test/shlibloadtest.c
+++ b/test/shlibloadtest.c
@@ -44,7 +44,7 @@ static OpenSSL_version_num_t OpenSSL_version_num;
 # define DSO_FREE "DSO_free"
 
 typedef void DSO;
-typedef DSO * (*DSO_dsobyaddr_t)(void (*addr)(), int flags);
+typedef DSO * (*DSO_dsobyaddr_t)(void (*addr)(void), int flags);
 typedef int (*DSO_free_t)(DSO *dso);
 
 static DSO_dsobyaddr_t DSO_dsobyaddr;
@@ -252,7 +252,7 @@ int main(int argc, char **argv)
         {
             DSO *hndl;
             /* use known symbol from crypto module */
-            if ((hndl = DSO_dsobyaddr((void (*)())ERR_get_error, 0)) != NULL) {
+            if ((hndl = DSO_dsobyaddr((void (*)(void))ERR_get_error, 0)) != NULL) {
                 DSO_free(hndl);
             } else {
                 printf("Unable to obtain DSO reference from crypto symbol\n");