From: Bruce Momjian <bruce@momjian.us>
Date: Thu, 12 Feb 2015 02:02:07 +0000 (-0500)
Subject: pg_upgrade:  preserve freeze info for postgres/template1 dbs
X-Git-Tag: REL9_5_ALPHA1~784
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=866f3017a88b9cb639f05c9ad413e5eafe0266e3;p=postgresql

pg_upgrade:  preserve freeze info for postgres/template1 dbs

pg_database.datfrozenxid and pg_database.datminmxid were not preserved
for the 'postgres' and 'template1' databases.  This could cause missing
clog file errors on access to user tables and indexes after upgrades in
these databases.

Backpatch through 9.0
---

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 3e3b4335a2..6a7a6415f6 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -1416,17 +1416,17 @@ dumpCreateDB(PGconn *conn)
 								  dbconnlimit);
 
 			appendPQExpBufferStr(buf, ";\n");
+		}
 
-			if (binary_upgrade)
-			{
-				appendPQExpBufferStr(buf, "-- For binary upgrade, set datfrozenxid and datminmxid.\n");
-				appendPQExpBuffer(buf, "UPDATE pg_catalog.pg_database "
-								"SET datfrozenxid = '%u', datminmxid = '%u' "
-								  "WHERE datname = ",
-								  dbfrozenxid, dbminmxid);
-				appendStringLiteralConn(buf, dbname, conn);
-				appendPQExpBufferStr(buf, ";\n");
-			}
+		if (binary_upgrade)
+		{
+			appendPQExpBufferStr(buf, "-- For binary upgrade, set datfrozenxid and datminmxid.\n");
+			appendPQExpBuffer(buf, "UPDATE pg_catalog.pg_database "
+							"SET datfrozenxid = '%u', datminmxid = '%u' "
+							  "WHERE datname = ",
+							  dbfrozenxid, dbminmxid);
+			appendStringLiteralConn(buf, dbname, conn);
+			appendPQExpBufferStr(buf, ";\n");
 		}
 
 		if (!skip_acls &&