From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 22 Nov 2006 21:13:11 +0000 (+0000)
Subject: Fix 1-byte buffer overrun when OID exceeds 1 billion.  This probably can't
X-Git-Tag: REL7_4_15~11
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8637cd1ee87b0436b0f72bf3179e4600429dbf7d;p=postgresql

Fix 1-byte buffer overrun when OID exceeds 1 billion.  This probably can't
cause any serious harm in normal cases, but if you have gcc buffer overrun
checking turned on, that will notice.  Found by Jack Orenstein.  Problem
was already fixed in CVS HEAD.
---

diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c
index 862fa4d667..4e15e0af47 100644
--- a/src/bin/psql/common.c
+++ b/src/bin/psql/common.c
@@ -3,7 +3,7 @@
  *
  * Copyright (c) 2000-2003, PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.76.2.1 2003/11/12 22:55:42 tgl Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.76.2.2 2006/11/22 21:13:11 tgl Exp $
  */
 #include "postgres_fe.h"
 #include "common.h"
@@ -556,7 +556,7 @@ PrintQueryResults(PGresult *results)
 
 		case PGRES_COMMAND_OK:
 			{
-				char		buf[10];
+				char		buf[16];
 
 				success = true;
 				sprintf(buf, "%u", (unsigned int) PQoidValue(results));