From: Robert Haas <rhaas@postgresql.org>
Date: Wed, 24 May 2017 20:30:47 +0000 (-0400)
Subject: Code review of get_qual_for_list.
X-Git-Tag: REL_10_BETA2~290
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=85c2b9a15a1d667b1e2cd580da8c1d9fef0af1e8;p=postgresql

Code review of get_qual_for_list.

We need not consider the case where both nulltest1 and nulltest2 are
NULL; the partition either accepts nulls or it does not.

Jeevan Ladhe.  I added an assertion.
---

diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
index 7304f6c29a..7f2fd58462 100644
--- a/src/backend/catalog/partition.c
+++ b/src/backend/catalog/partition.c
@@ -1383,15 +1383,14 @@ get_qual_for_list(PartitionKey key, PartitionBoundSpec *spec)
 
 	if (nulltest1)
 		result = list_make2(nulltest1, opexpr);
-	else if (nulltest2)
+	else
 	{
 		Expr	   *or;
 
+		Assert(nulltest2 != NULL);
 		or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1);
 		result = list_make1(or);
 	}
-	else
-		result = list_make1(opexpr);
 
 	return result;
 }