From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Fri, 23 Dec 2022 21:12:45 +0000 (-0800)
Subject: dotgen make_flat_adj_edges: remove unnecessary dynamic allocation of 'attrs'
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=85ae02ffca41932b792c5b1e43f041b6a1ecee6a;p=graphviz

dotgen make_flat_adj_edges: remove unnecessary dynamic allocation of 'attrs'
---

diff --git a/lib/dotgen/dotsplines.c b/lib/dotgen/dotsplines.c
index 5f740c35a..901b23371 100644
--- a/lib/dotgen/dotsplines.c
+++ b/lib/dotgen/dotsplines.c
@@ -918,7 +918,6 @@ cleanupCloneGraph (graph_t* g, attr_state_t* attr_state)
     G_ordering = attr_state->G_ordering;
     State = attr_state->State;
 
-    free (attr_state);
     dot_cleanup(g);
     agclose(g);
 }
@@ -1233,7 +1232,6 @@ make_flat_adj_edges(graph_t* g, edge_t** edges, int ind, int cnt, edge_t* e0,
     double midx, midy, leftx, rightx;
     pointf   del;
     edge_t* hvye = NULL;
-    attr_state_t* attrs;
     static int warned;
 
     tn = agtail(e0), hn = aghead(e0);
@@ -1265,8 +1263,8 @@ make_flat_adj_edges(graph_t* g, edge_t** edges, int ind, int cnt, edge_t* e0,
 	return;
     }
 
-    attrs = gv_alloc(sizeof(attr_state_t));
-    auxg = cloneGraph (g, attrs);
+    attr_state_t attrs = {0};
+    auxg = cloneGraph(g, &attrs);
     subg = agsubg (auxg, "xxx",1);
     agbindrec(subg, "Agraphinfo_t", sizeof(Agraphinfo_t), true);
     agset (subg, "rank", "source");
@@ -1367,7 +1365,7 @@ make_flat_adj_edges(graph_t* g, edge_t** edges, int ind, int cnt, edge_t* e0,
 	}
     }
 
-    cleanupCloneGraph (auxg, attrs);
+    cleanupCloneGraph(auxg, &attrs);
 }
 
 /* makeFlatEnd;