From: Günther Noack <gnoack@google.com>
Date: Thu, 1 May 2014 11:33:11 +0000 (+0200)
Subject: Avoid out-of-bounds write in SSL_get_shared_ciphers
X-Git-Tag: OpenSSL_1_0_2-beta2~220
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8571902e238ba2ef1517185c2a662c03f51dc1bf;p=openssl

Avoid out-of-bounds write in SSL_get_shared_ciphers

PR: 3317
---

diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index 0103296aa9..0a7e2aad2d 100644
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -1467,6 +1467,9 @@ char *SSL_get_shared_ciphers(const SSL *s,char *buf,int len)
 		(len < 2))
 		return(NULL);
 
+	if (sk_SSL_CIPHER_num(sk) == 0)
+		return NULL;
+
 	p=buf;
 	sk=s->session->ciphers;
 	for (i=0; i<sk_SSL_CIPHER_num(sk); i++)