From: Benjamin Kaduk <bkaduk@akamai.com>
Date: Fri, 27 Oct 2017 14:52:06 +0000 (-0500)
Subject: Fix memory leak in crltest error case
X-Git-Tag: OpenSSL_1_1_1-pre1~502
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=85155346b3ca2dcdecf018dc8db9df94ceebeb0d;p=openssl

Fix memory leak in crltest error case

This would cut out some distracting noise in the test output
if we ended up hitting these error cases.

Reported by Coverity.

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/4602)
---

diff --git a/test/crltest.c b/test/crltest.c
index 5ea9cdc4ee..738ca23ce5 100644
--- a/test/crltest.c
+++ b/test/crltest.c
@@ -267,6 +267,7 @@ static int verify(X509 *leaf, X509 *root, STACK_OF(X509_CRL) *crls,
     if (flags)
         X509_VERIFY_PARAM_set_flags(param, flags);
     X509_STORE_CTX_set0_param(ctx, param);
+    param = NULL;
 
     ERR_clear_error();
     status = X509_verify_cert(ctx) == 1 ? X509_V_OK
@@ -274,6 +275,7 @@ static int verify(X509 *leaf, X509 *root, STACK_OF(X509_CRL) *crls,
 err:
     sk_X509_pop_free(roots, X509_free);
     sk_X509_CRL_pop_free(crls, X509_CRL_free);
+    X509_VERIFY_PARAM_free(param);
     X509_STORE_CTX_free(ctx);
     X509_STORE_free(store);
     return status;