From: Reid Kleckner <rnk@google.com>
Date: Tue, 17 May 2016 16:50:45 +0000 (+0000)
Subject: Tentatively enable -Wcast-calling-convention by default
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=848c2ee39363503ff4ac8c0fbf9b00c135e9a41b;p=clang

Tentatively enable -Wcast-calling-convention by default

In Chrome, this would have found two true positives around CreateThread
if we hadn't already fixed them while rolling out ASan. We didn't get
any other hits in Chrome. I'm curious to hear if this warning finds
anything in other projects.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@269780 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td
index 322427862f..42de37a4be 100644
--- a/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/include/clang/Basic/DiagnosticSemaKinds.td
@@ -6639,7 +6639,7 @@ def warn_function_def_in_objc_container : Warning<
 def warn_cast_calling_conv : Warning<
   "cast between incompatible calling conventions '%0' and '%1'; "
   "calls through this pointer may abort at runtime">,
-  InGroup<DiagGroup<"cast-calling-convention">>, DefaultIgnore;
+  InGroup<DiagGroup<"cast-calling-convention">>;
 def note_change_calling_conv_fixit : Note<
   "consider defining %0 with the '%1' calling convention">;
 def warn_bad_function_cast : Warning<