From: Kaelyn Uhrain <rikka@google.com>
Date: Thu, 4 Aug 2011 23:30:54 +0000 (+0000)
Subject: Fix a small bug where DiagnoseEmptyLookup would no longer print any messages
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=844d5728557a324fe10ad990dd537e59780873ef;p=clang

Fix a small bug where DiagnoseEmptyLookup would no longer print any messages
when performing typo correction involving any overloaded template functions.

The added test cases, while currently demontrating sub-optimal behavior, will
not trigger any messages without the 1-line change to SemaExpr.cpp.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@136943 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index 6ace3e92e6..ffa092aad1 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -1468,8 +1468,7 @@ bool Sema::DiagnoseEmptyLookup(Scope *S, CXXScopeSpec &SS, LookupResult &R,
             ND = Best->Function;
             break;
           default:
-            // Don't try to recover; it won't work.
-            return true;
+            break;
         }
       }
       R.addDecl(ND);
diff --git a/test/SemaCXX/function-overload-typo-crash.cpp b/test/SemaCXX/function-overload-typo-crash.cpp
index 580f27a12a..a0f70dfbdb 100644
--- a/test/SemaCXX/function-overload-typo-crash.cpp
+++ b/test/SemaCXX/function-overload-typo-crash.cpp
@@ -10,3 +10,22 @@ void f() {
   fin(); //expected-error {{use of undeclared identifier 'fin'; did you mean 'min'}}
   fax(0); //expected-error {{use of undeclared identifier 'fax'; did you mean 'max'}}
 }
+
+// TODO: Add proper function overloading resolution for template functions
+template <typename T> void somefunc(T*, T*);
+template <typename T> void somefunc(const T[]);
+template <typename T1, typename T2> void somefunc(T1*, T2*);
+template <typename T1, typename T2> void somefunc(T1*, const T2[]); //expected-note 5 {{'somefunc' declared here}} \
+                                                                    //expected-note {{candidate function template not viable: requires 2 arguments, but 1 was provided}} TODO this shouldn't happen
+
+void c() {
+  int *i = 0, *j = 0;
+  const int x[] = {1, 2, 3};
+  long *l = 0;
+  somefun(i, j); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
+  somefun(x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} \
+              //expected-error {{no matching function for call to 'somefunc'}} TODO this shouldn't happen
+  somefun(i, l); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
+  somefun(l, x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
+  somefun(i, x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
+}