From: Antony Dovgal <tony2001@php.net>
Date: Fri, 18 Aug 2006 12:50:36 +0000 (+0000)
Subject: add a notice to fgetcsv() when delimiter or enclosure is longer than 1 char
X-Git-Tag: RELEASE_1_0_0RC1~1931
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=84060835f7d6feb2ad636d8cb31f934284247031;p=php

add a notice to fgetcsv() when delimiter or enclosure is longer than 1 char
(feature request #38496)
---

diff --git a/ext/standard/file.c b/ext/standard/file.c
index 9e53da1f06..6e6c1faf23 100644
--- a/ext/standard/file.c
+++ b/ext/standard/file.c
@@ -2081,6 +2081,8 @@ PHP_FUNCTION(fgetcsv)
 			if (delimiter_str_len < 1) {
 				php_error_docref(NULL TSRMLS_CC, E_WARNING, "delimiter must be a character");
 				RETURN_FALSE;
+			} else if (delimiter_str_len > 1) {
+				php_error_docref(NULL TSRMLS_CC, E_NOTICE, "delimiter must be a single character");
 			}
 
 			/* use first character from string */
@@ -2091,7 +2093,10 @@ PHP_FUNCTION(fgetcsv)
 			if (enclosure_str_len < 1) {
 				php_error_docref(NULL TSRMLS_CC, E_WARNING, "enclosure must be a character");
 				RETURN_FALSE;
+			} else if (enclosure_str_len > 1) {
+				php_error_docref(NULL TSRMLS_CC, E_NOTICE, "enclosure must be a single character");
 			}
+
 			/* use first character from string */
 			enclosure = enclosure_str[0];
 		}