From: Zachary Ware <zachary.ware@gmail.com>
Date: Tue, 13 Oct 2015 04:27:58 +0000 (-0500)
Subject: Issue #25093: Fix test_tcl's testloadWithUNC for paths with spaces
X-Git-Tag: v3.5.1rc1~163^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=83fd0a81a4afff60339b0ead31c3b8317b29fd55;p=python

Issue #25093: Fix test_tcl's testloadWithUNC for paths with spaces

Patch by Serhiy Storchaka.
---

diff --git a/Lib/test/test_tcl.py b/Lib/test/test_tcl.py
index 66e9d49dfe..b6565631b7 100644
--- a/Lib/test/test_tcl.py
+++ b/Lib/test/test_tcl.py
@@ -1,5 +1,6 @@
 import unittest
 import re
+import subprocess
 import sys
 import os
 from test import support
@@ -246,11 +247,10 @@ class TclTest(unittest.TestCase):
 
         with support.EnvironmentVarGuard() as env:
             env.unset("TCL_LIBRARY")
-            f = os.popen('%s -c "import tkinter; print(tkinter)"' % (unc_name,))
+            stdout = subprocess.check_output(
+                    [unc_name, '-c', 'import tkinter; print(tkinter)'])
 
-        self.assertIn('tkinter', f.read())
-        # exit code must be zero
-        self.assertEqual(f.close(), None)
+        self.assertIn(b'tkinter', stdout)
 
     def test_exprstring(self):
         tcl = self.interp