From: Antoine Pitrou Date: Sat, 2 Jan 2010 21:47:10 +0000 (+0000) Subject: Add tests for issue #7458: str.rfind() would crash when called with an invalid X-Git-Tag: v2.7a2~49 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=83f86e8e98ff789f1c2832860ff78a59562db37d;p=python Add tests for issue #7458: str.rfind() would crash when called with an invalid start value. The offending code itself was removed as part of #7462. This patch by Victor Stinner. --- diff --git a/Lib/test/string_tests.py b/Lib/test/string_tests.py index 988372dd71..5d4f9eb6aa 100644 --- a/Lib/test/string_tests.py +++ b/Lib/test/string_tests.py @@ -185,6 +185,9 @@ class CommonTest(unittest.TestCase): self.checkequal(-1, '', 'find', 'xx', 1, 1) self.checkequal(-1, '', 'find', 'xx', sys.maxint, 0) + # issue 7458 + self.checkequal(-1, 'ab', 'find', 'xxx', sys.maxsize + 1, 0) + # For a variety of combinations, # verify that str.find() matches __contains__ # and that the found substring is really at that location @@ -255,6 +258,9 @@ class CommonTest(unittest.TestCase): if loc != -1: self.assertEqual(i[loc:loc+len(j)], j) + # issue 7458 + self.checkequal(-1, 'ab', 'rfind', 'xxx', sys.maxsize + 1, 0) + def test_index(self): self.checkequal(0, 'abcdefghiabc', 'index', '') self.checkequal(3, 'abcdefghiabc', 'index', 'def')