From: Rasmus Lerdorf <rasmus@php.net>
Date: Mon, 30 Jun 2003 18:22:53 +0000 (+0000)
Subject: Fix 3 tests that didn't adequately specify the .ini settings they rely on
X-Git-Tag: BEFORE_ARG_INFO~524
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=832ffd197040f24d6e2074dc38a8a92885c5e462;p=php

Fix 3 tests that didn't adequately specify the .ini settings they rely on
---

diff --git a/ext/standard/tests/general_functions/getopt.phpt b/ext/standard/tests/general_functions/getopt.phpt
index 13a4fa558f..e861268459 100644
--- a/ext/standard/tests/general_functions/getopt.phpt
+++ b/ext/standard/tests/general_functions/getopt.phpt
@@ -2,14 +2,14 @@
 getopt
 --ARGS--
 -v -h -d test -m 1234 -t -j
+--INI--
+register_argc_argv=On
+variables_order=GPS
 --SKIPIF--
 <?php
 	if (substr(PHP_OS, 0, 3) == 'WIN') {
 		die('skip getopt() is currently not available on Windows');
 	}
-	if (!ini_get('register_argc_argv')) {
-		die("skip this test needs register_argc_argv to be enabled");
-	}
 ?>
 --FILE--
 <?php
diff --git a/tests/basic/012.phpt b/tests/basic/012.phpt
index 7e70f9a018..3297853286 100644
--- a/tests/basic/012.phpt
+++ b/tests/basic/012.phpt
@@ -4,6 +4,7 @@ Testing $argc and $argv handling (cli)
 <?php if(php_sapi_name()!='cli') echo 'skip'; ?>
 --INI--
 register_argc_argv=1
+variables_order=GPS
 --ARGS--
 ab cd ef 123 test
 --FILE--
diff --git a/tests/lang/bug21800.phpt b/tests/lang/bug21800.phpt
index b835425c3d..72755e29a5 100644
--- a/tests/lang/bug21800.phpt
+++ b/tests/lang/bug21800.phpt
@@ -4,7 +4,8 @@ Bug #21800 (Segfault under interactive mode)
 <?php (PHP_SAPI != 'cli') and print "SKIP PHP binary is not cli"; ?>
 --FILE--
 <?php
-$fh = popen("{$_ENV['TEST_PHP_EXECUTABLE']} -a", 'w');
+$exe = getenv('TEST_PHP_EXECUTABLE');
+$fh = popen("$exe -a", 'w');
 if ($fh !== false) {
 	fwrite($fh, "<?php echo ':test:'; ?>\n\n");
 	fclose($fh);