From: Derick Rethans <derick@php.net>
Date: Fri, 22 Feb 2008 17:49:30 +0000 (+0000)
Subject: - MFH: Fixed bug #44216 (strftime segfaults on large negative value).
X-Git-Tag: php-5.2.6RC1~19
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8241ee2226a6083442f554c430537cc0d89b863c;p=php

- MFH: Fixed bug #44216 (strftime segfaults on large negative value).
---

diff --git a/NEWS b/NEWS
index 557776462d..20702f6671 100644
--- a/NEWS
+++ b/NEWS
@@ -11,6 +11,7 @@ PHP                                                                        NEWS
 - Upgraded PCRE to version 7.6 (Nuno)
 
 
+- Fixed bug #44216 (strftime segfaults on large negative value). (Derick)
 - Fixed bug #44209 (strtotime() doesn't support 64 bit timestamps on 64 bit
   platforms). (Derick)
 - Fixed bug #44197 (socket array keys lost on socket_select). (Felipe)
diff --git a/ext/date/lib/dow.c b/ext/date/lib/dow.c
index 876c7dfcb2..def1b3e59e 100644
--- a/ext/date/lib/dow.c
+++ b/ext/date/lib/dow.c
@@ -35,10 +35,12 @@ static timelib_sll timelib_day_of_week_ex(timelib_sll y, timelib_sll m, timelib_
 {
 	timelib_sll c1, y1, m1, dow;
 
-	/* Only valid for Gregorian calendar */
+	/* Only valid for Gregorian calendar, commented out as we don't handle
+	 * julian calendar. We just return the 'wrong' day of week to be
+	 * consistent.
 	if (y < 1753) {
 		return -1;
-	}
+	} */
 	c1 = century_value(y / 100);
 	y1 = (y % 100);
 	m1 = timelib_is_leap(y) ? m_table_leap[m] : m_table_common[m];